-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update wholegraph #65
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems ok to me
@linhu-nv I have some questions:
|
Ah wait, I just noticed CI did not actually run here. We need to run the tests. |
/ok to test |
/merge |
Hi @jameslamb , I noticed that this cugraph-gnn repo just diverges with wholegraph repo since some wholegraph version in July or earlier. This PR just updates every source file of "core code", and doesn't update files such as those get changed in pr 228 230 231 . So my question is, do we also need to sync those files/prs to this repo manually? If not, then I think it's ok to start publishing packages in this repo. thx |
I answered this offline as well, but putting it here for those finding this from GitHub search... the changes you mentioned have all already been synced here. So we can move forward with publishing packages from here 😁 |
Removes the workflow for publishing nightly packages from this repo. In 24.12, development for this project is shifting to https://github.com/rapidsai/cugraph-gnn. That repo is now fully up to date with this library's source code, as of rapidsai/cugraph-gnn#65 ## Notes for Reviewers ### Why not just archive the repo? We're not quite ready for that yet. Other changes need to be made to RAPIDS devcontainers, integration tests, etc. for 24.12. So this PR leaves the ability to build the project from source in place, to reduce the amount of coordination needed for those other changes. Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Bradley Dice (https://github.com/bdice) URL: #233
This PR updates wholegraph to the latest version.
Most of these changes were pulled from a mix of the following:
https://github.com/rapidsai/wholegraph/pull/227
https://github.com/rapidsai/wholegraph/pull/194