Remove cudf._lib.hash in favor of inlining pylibcudf #17345
Merged
+67
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Python
wence-
approved these changes
Nov 18, 2024
Comment on lines
+2930
to
+2931
| else: | ||
| raise ValueError(f"Unsupported hashing algorithm {method}.") |
There was a problem hiding this comment.
nit: Could use assert_never(method), although in that case you don't get as nice an error message
There was a problem hiding this comment.
Ah didn't know about assert_never, but I think it would be good to have an informative error message here
galipremsagar
approved these changes
Nov 18, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Contributes to #17317
Checklist