-
Notifications
You must be signed in to change notification settings - Fork 908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate CSV writer to pylibcudf #17163
Open
Matt711
wants to merge
31
commits into
rapidsai:branch-24.12
Choose a base branch
from
Matt711:pylibcudf-io-csv
base: branch-24.12
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+470
−113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matt711
added
feature request
New feature or request
non-breaking
Non-breaking change
labels
Oct 24, 2024
github-actions
bot
added
Python
Affects Python cuDF API.
pylibcudf
Issues specific to the pylibcudf package
labels
Oct 24, 2024
Matt711
commented
Oct 24, 2024
Matt711
commented
Oct 24, 2024
Matt711
changed the title
[WIP] Migrate CSV writer to pylibcudf
Migrate CSV writer to pylibcudf
Nov 6, 2024
Matt711
commented
Nov 7, 2024
mroeschke
reviewed
Nov 7, 2024
mroeschke
reviewed
Nov 7, 2024
mroeschke
reviewed
Nov 7, 2024
mroeschke
reviewed
Nov 7, 2024
mroeschke
reviewed
Nov 7, 2024
davidwendt
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving C++ header change.
mroeschke
reviewed
Nov 12, 2024
wence-
reviewed
Nov 15, 2024
wence-
reviewed
Nov 15, 2024
wence-
reviewed
Nov 15, 2024
Matt711
commented
Nov 15, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3 - Ready for Review
Ready for review by team
feature request
New feature or request
libcudf
Affects libcudf (C++/CUDA) code.
non-breaking
Non-breaking change
pylibcudf
Issues specific to the pylibcudf package
Python
Affects Python cuDF API.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Apart of #15162
Checklist