-
Notifications
You must be signed in to change notification settings - Fork 908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support negative preceding/following for ROW window functions #14093
Merged
rapids-bot
merged 18 commits into
rapidsai:branch-23.10
from
mythrocks:offset-row-windows-wip
Sep 21, 2023
Merged
Support negative preceding/following for ROW window functions #14093
rapids-bot
merged 18 commits into
rapidsai:branch-23.10
from
mythrocks:offset-row-windows-wip
Sep 21, 2023
Commits on Sep 5, 2023
-
Support negative preceding/following for ROW window functions
This commit adds support for "offset" ROW windows, where the preceding and following window bounds are allowed to have negative values. This allows window definitions to exclude the current row entirely. Prior to this change, ROW-based windows *had* to include the current row, causing `preceding` and `following` to support only non-negative values. Additionally, the inclusion of the current row would count against the `min_periods` check. The following is an example of the new "negative" semantics. Consider the input: ```c++ auto const row = ints_column{1, 2, 3, 4}; ``` If the window bounds are specified as (preceding=3, following=-1), then the window for the third row (`3`) is `{1, 2}`. `following=-1` indicates a "following" row *before* the current row. A negative value for `preceding` follows the existing convention of including the current row. This makes it slightly more involved: 1. `preceding=2` indicates *one* row before the current row. 2. `preceding=1` indicates the current row. 3. `preceding=0` indicates one row past (i.e. after) the current row. 4. `preceding=-1` indicates two rows after the current row. Et cetera. `min_periods` checks continue to be honoured as before, but the requirement for positive `min_periods` is dropped. `min_periods` only need be non-negative. Signed-off-by: MithunR <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 9f6acc6 - Browse repository at this point
Copy the full SHA 9f6acc6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7e4ae8b - Browse repository at this point
Copy the full SHA 7e4ae8bView commit details -
Configuration menu - View commit details
-
Copy full SHA for a577d2e - Browse repository at this point
Copy the full SHA a577d2eView commit details -
Configuration menu - View commit details
-
Copy full SHA for f2a9e1e - Browse repository at this point
Copy the full SHA f2a9e1eView commit details
Commits on Sep 10, 2023
-
Configuration menu - View commit details
-
Copy full SHA for e616ecc - Browse repository at this point
Copy the full SHA e616eccView commit details
Commits on Sep 11, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 6d65898 - Browse repository at this point
Copy the full SHA 6d65898View commit details -
Materialized preceding/following offsets for fixed windows.
Also, removed prints.
Configuration menu - View commit details
-
Copy full SHA for eaff7dd - Browse repository at this point
Copy the full SHA eaff7ddView commit details -
Configuration menu - View commit details
-
Copy full SHA for c3e7f8b - Browse repository at this point
Copy the full SHA c3e7f8bView commit details
Commits on Sep 12, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 4aca25e - Browse repository at this point
Copy the full SHA 4aca25eView commit details
Commits on Sep 18, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 589f2a5 - Browse repository at this point
Copy the full SHA 589f2a5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5f310a2 - Browse repository at this point
Copy the full SHA 5f310a2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4d4683c - Browse repository at this point
Copy the full SHA 4d4683cView commit details
Commits on Sep 19, 2023
-
Configuration menu - View commit details
-
Copy full SHA for ada90c2 - Browse repository at this point
Copy the full SHA ada90c2View commit details -
Configuration menu - View commit details
-
Copy full SHA for f7c504b - Browse repository at this point
Copy the full SHA f7c504bView commit details
Commits on Sep 20, 2023
-
Updated grouped_rolling_window documentation:
This now explains the semantics for negative window bounds.
Configuration menu - View commit details
-
Copy full SHA for da78c8e - Browse repository at this point
Copy the full SHA da78c8eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1821eaf - Browse repository at this point
Copy the full SHA 1821eafView commit details -
Configuration menu - View commit details
-
Copy full SHA for 46de250 - Browse repository at this point
Copy the full SHA 46de250View commit details -
Configuration menu - View commit details
-
Copy full SHA for b66fd14 - Browse repository at this point
Copy the full SHA b66fd14View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.