-
Notifications
You must be signed in to change notification settings - Fork 908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raise NotImplementedError in to_datetime if Z (or tz component) in string #14074
Raise NotImplementedError in to_datetime if Z (or tz component) in string #14074
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this broke some other tests that were expecting this to work, those need updating as well.
@@ -1278,12 +1278,8 @@ def test_datetime_reductions(data, op, dtype): | |||
@pytest.mark.parametrize("dtype", DATETIME_TYPES) | |||
def test_datetime_infer_format(data, dtype): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test verifies if our string-to-time conversions work properly until nano-second time resolution. Can you add another set of tests that drop the timezone="UTC"
parameter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I'll add back that testing in this test
/merge |
Description
closes #14039
Avoids this discrepancy when a date string has a tz component
Checklist