Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove debug print in a Parquet test #14063

Merged
merged 7 commits into from
Sep 11, 2023
Merged

Remove debug print in a Parquet test #14063

Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
75c4fa0
if print_enabled
vuule Sep 7, 2023
3a4f684
Merge branch 'branch-23.10' into disable-test-print
vuule Sep 7, 2023
97e9896
Merge branch 'branch-23.10' into disable-test-print
vuule Sep 8, 2023
faabcdd
Merge branch 'branch-23.10' into disable-test-print
vuule Sep 8, 2023
9a6037b
remove
vuule Sep 11, 2023
fd978a6
Merge branch 'branch-23.10' of https://github.com/rapidsai/cudf into …
vuule Sep 11, 2023
a7b3d99
Merge branch 'disable-test-print' of https://github.com/vuule/cudf in…
vuule Sep 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion cpp/tests/io/parquet_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,9 @@
#include <random>
#include <type_traits>

// Set this to true to enable printing, for debugging.
auto constexpr print_enabled = false;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be read from env variable?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copied the mechanism from structs_tests. Either way, this is removed now :)

vuule marked this conversation as resolved.
Show resolved Hide resolved

template <typename T, typename SourceElementT = T>
using column_wrapper =
typename std::conditional<std::is_same_v<T, cudf::string_view>,
Expand Down Expand Up @@ -6534,7 +6537,7 @@ TEST_F(ParquetReaderTest, FilterFloatNAN)
auto col0 = cudf::test::fixed_width_column_wrapper<float>(elements, elements + num_rows);
auto col1 = cudf::test::fixed_width_column_wrapper<double>(elements, elements + num_rows);

cudf::test::print(col0);
if constexpr (print_enabled) { cudf::test::print(col0); }
vuule marked this conversation as resolved.
Show resolved Hide resolved
auto const written_table = table_view{{col0, col1}};
auto const filepath = temp_env->get_temp_filepath("FilterFloatNAN.parquet");
{
Expand Down