Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outgoing message improvements #25

Merged
merged 4 commits into from
May 13, 2016
Merged

Outgoing message improvements #25

merged 4 commits into from
May 13, 2016

Conversation

rowanseymour
Copy link
Contributor

  • Splits the generic message sending endpoint into three more logical endpoints for case replies, bulk replies and forwards
  • Records contacts and URNs on the outgoing message
  • Fixes a bug on the forwarding modal dialog

@@ -84,15 +84,12 @@ def create_label(self, org, name):
"""

@abstractmethod
def create_outgoing(self, org, text, contacts, urns):
def push_outgoing(self, org, outgoing):
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously the pattern for creating something that exists in both RapidPro and CasePro, was

  1. Use an API call to create it in RapidPro
  2. Get the identifier used by RapidPro
  3. Create locally with that identifier

But for things that aren't being pushed to the backend - this pattern makes more sense:

  1. Create locally
  2. Optionally push to backend and update with returned identifier

Another advantage of this is that the local outgoing message is still created even if the RapidPro API call fails.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 94.638% when pulling 1017c42 on message_sending into 1ef04e6 on master.

@nicpottier
Copy link
Member

It's so beautiful!

@coveralls
Copy link

Coverage Status

Coverage increased (+1.1%) to 95.858% when pulling c6c6a53 on message_sending into 1ef04e6 on master.

@rowanseymour rowanseymour merged commit 3a10af5 into master May 13, 2016
@rowanseymour rowanseymour deleted the message_sending branch May 13, 2016 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants