Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ci workflow warnings #70

Merged
merged 1 commit into from
Feb 19, 2024
Merged

fix ci workflow warnings #70

merged 1 commit into from
Feb 19, 2024

Conversation

nwagner84
Copy link
Contributor

@nwagner84 nwagner84 commented Feb 17, 2024

This PR uses dtolnay/rust-toolchain to setup the Rust toolchain. This fixes the deprecation warnings like:


build (ubuntu-latest, beta)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

Signed-off-by: Nico Wagner <[email protected]>
Copy link
Member

@dguo dguo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@@ -18,10 +18,9 @@ jobs:
steps:
- uses: actions/checkout@v4
- name: Install Rust
uses: actions-rs/toolchain@v1
uses: dtolnay/rust-toolchain@master
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was confused at first why this uses @master, but I see the docs say:

When passing an explicit toolchain as an input instead of @Rev, you'll want to use "dtolnay/rust-toolchain@master" as the revision of the action.

@dguo dguo merged commit 7beabcb into rapidfuzz:main Feb 19, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants