Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing kubebuilder generation #993

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

anmazzotti
Copy link
Contributor

What this PR does / why we need it:

Looks like the RBAC rules where never correctly generated.
This is an attempt to fix it, should also fix #989

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #989

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@anmazzotti anmazzotti requested a review from a team as a code owner January 9, 2025 14:06
@anmazzotti anmazzotti force-pushed the fix_settings_rbac branch 2 times, most recently from ff9ac9d to 1152327 Compare January 9, 2025 14:36
@thehejik
Copy link
Collaborator

thehejik commented Jan 9, 2025

Cluster is still Pending and another error occurred: (using rancher's default agent-tls-mode: strict):

E0109 16:31:27.585063 1 controller.go:316] "Reconciler error" err="error reconciling cluster: error getting CA cert: invalid agent-tls-mode setting value: " controller="cluster" controllerGroup="cluster.x-k8s.io" controllerKind="Cluster" Cluster="default/th-rke2-capv-cpi" namespace="default" name="th-rke2-capv-cpi" reconcileID="e5937f7b-e7e8-4711-a146-06c0f4266fc1"

Signed-off-by: Andrea Mazzotti <[email protected]>
@anmazzotti
Copy link
Contributor Author

FYI I also ran the e2e tests against this PR: https://github.com/rancher/turtles/actions/runs/12705933743
They seem to pass (except the usual one failing)

@anmazzotti anmazzotti self-assigned this Jan 10, 2025
@Danil-Grigorev
Copy link
Contributor

Danil-Grigorev commented Jan 10, 2025

Cluster is still Pending and another error occurred: (using rancher's default agent-tls-mode: strict):

E0109 16:31:27.585063 1 controller.go:316] "Reconciler error" err="error reconciling cluster: error getting CA cert: invalid agent-tls-mode setting value: " controller="cluster" controllerGroup="cluster.x-k8s.io" controllerKind="Cluster" Cluster="default/th-rke2-capv-cpi" namespace="default" name="th-rke2-capv-cpi" reconcileID="e5937f7b-e7e8-4711-a146-06c0f4266fc1"

@thehejik Can you please open an issue? On which rancher version it is appearing?

@thehejik
Copy link
Collaborator

I will retest manually, e2e tests are still using --insecure-skip-verify=true here

@thehejik
Copy link
Collaborator

It doesn't work, followup issue opened #994

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Cluster import not successful when agent-tls-mode flag is enabled
3 participants