Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated Upload video behavior to reduce storage #275

Merged
merged 1 commit into from
Feb 4, 2025
Merged

Updated Upload video behavior to reduce storage #275

merged 1 commit into from
Feb 4, 2025

Conversation

sbulage
Copy link
Collaborator

@sbulage sbulage commented Feb 4, 2025 •
edited
Loading

  • This PR fix the extra Upload video when there is no upgrade job run.
  • Extended same logic to screenshot step too.

@sbulage sbulage added the fleet-e2e-ci Improvements or additions to the CI framework label Feb 4, 2025
@sbulage sbulage self-assigned this Feb 4, 2025
@sbulage sbulage force-pushed the fix_extra_artifacts branch from caaf12c to f4c4cf3 Compare February 4, 2025 16:31
@sbulage
Copy link
Collaborator Author

sbulage commented Feb 4, 2025

CI run: https://github.com/rancher/fleet-e2e/actions/runs/13140020707
to check whether it will create new artifact but it didn't created it.

image

@sbulage sbulage requested a review from mmartin24 February 4, 2025 16:33
@sbulage
Copy link
Collaborator Author

sbulage commented Feb 4, 2025

CI for PR check will not required to check this change.

mmartin24
mmartin24 approved these changes Feb 4, 2025
View reviewed changes
Copy link
Collaborator

@mmartin24 mmartin24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sbulage sbulage merged commit 19d6868 into main Feb 4, 2025
3 checks passed
@sbulage sbulage deleted the fix_extra_artifacts branch February 4, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmartin24 mmartin24 mmartin24 approved these changes

Assignees

@sbulage sbulage

Labels
fleet-e2e-ci Improvements or additions to the CI framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbulage @mmartin24