Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing new lane to test PROXY now and later Rancher upgrade testing #206

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sbulage
Copy link
Collaborator

@sbulage sbulage commented Sep 24, 2024

Partly fixes: #196

@sbulage sbulage added the fleet-e2e-ci Improvements or additions to the CI framework label Sep 24, 2024
@sbulage sbulage self-assigned this Sep 24, 2024
refresh_pattern -i (/cgi-bin/|\?) 0 0% 0
refresh_pattern . 0 20% 4320

debug_options ALL,1 11,3 20,3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a newline

Copy link
Collaborator

@mmartin24 mmartin24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a question. Other than that we will see how it goes once part 2 is on.
Approved.

.github/scripts/squid.conf Show resolved Hide resolved
.github/workflows/ui-rm-upgrade-proxy.yaml Show resolved Hide resolved
Copy link
Collaborator

@thehejik thehejik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is incomplete and can't work as it is:

  • missing proxy configuration for underlying k8s
  • ele-testhelpers for setting rancher proxy URL is using hardcoded value which can be different in your environment

@sbulage sbulage force-pushed the ci_new_lane_with_proxy branch from 66a918c to 8b7d03e Compare September 27, 2024 13:46
@sbulage
Copy link
Collaborator Author

sbulage commented Sep 27, 2024

This PR is incomplete and can't work as it is:

  • missing proxy configuration for underlying k8s

Currently, I am working on this to accommodate changes to existing k3s installation.

  • ele-testhelpers for setting rancher proxy URL is using hardcoded value which can be different in your environment

This is done.

@sbulage sbulage force-pushed the ci_new_lane_with_proxy branch from 8b7d03e to 17fb38c Compare October 24, 2024 12:49
@thehejik
Copy link
Collaborator

Only missing piece is the k3s configuration :)

What prevents you to add something like this into install_suite.go when proxy is ON?

cat <<EOF | sudo tee /etc/default/k3s > /dev/null
HTTP_PROXY=http://${proxy_host}
HTTPS_PROXY=http://${proxy_host}
NO_PROXY=127.0.0.0/8,10.0.0.0/8,cattle-system.svc,172.16.0.0/12,192.168.0.0/16,.svc,.cluster.local
EOF

@sbulage
Copy link
Collaborator Author

sbulage commented Oct 24, 2024

Only missing piece is the k3s configuration :)

What prevents you to add something like this into install_suite.go when proxy is ON?

cat <<EOF | sudo tee /etc/default/k3s > /dev/null
HTTP_PROXY=http://${proxy_host}
HTTPS_PROXY=http://${proxy_host}
NO_PROXY=127.0.0.0/8,10.0.0.0/8,cattle-system.svc,172.16.0.0/12,192.168.0.0/16,.svc,.cluster.local
EOF

Nothing is stopping me to add this option to K3s, I will add it and update the PR.

@sbulage sbulage force-pushed the ci_new_lane_with_proxy branch 4 times, most recently from 5b50554 to f3838f1 Compare October 25, 2024 12:20
@sbulage sbulage requested a review from thehejik October 25, 2024 12:23
@sbulage sbulage force-pushed the ci_new_lane_with_proxy branch 7 times, most recently from 997772d to c588817 Compare October 29, 2024 08:40
@sbulage sbulage force-pushed the ci_new_lane_with_proxy branch 2 times, most recently from cdd4cca to 6e40534 Compare November 14, 2024 14:31
@sbulage sbulage force-pushed the ci_new_lane_with_proxy branch from 6e40534 to 56d66a8 Compare November 26, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fleet-e2e-ci Improvements or additions to the CI framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Try automate Rancher upgrade
3 participants