Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SeedImage.status.checksumURL #827

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

anmazzotti
Copy link
Contributor

Part of: #823

This PR adds the SeedImage.status.checksumURL.

The checksum is created with the image (raw or iso), and served by the SeedImage's pod (as images are now).

Also the downloadURL now contains a filename matching the actual served file:

Previous:

downloadURL: https://172.18.0.2.sslip.io/elemental/seedimage/cplb4w8hlvnnd98l6jbwgsqfns9hcvsvq2hbfwz4k5vnnf5zw8bj6h/fire-nodes.iso

Current:

downloadURL: https://172.18.0.2.sslip.io/elemental/seedimage/p88nj2wb48xppjdh6r988bhx86sqrjqt4v8j7fzmvghvbjgrs56dbx/fire-nodes-2024-08-21T14:32:46Z.iso

Same applies for the checksum file:

checksumURL: https://172.18.0.2.sslip.io/elemental/seedimage/p88nj2wb48xppjdh6r988bhx86sqrjqt4v8j7fzmvghvbjgrs56dbx/fire-nodes-2024-08-21T14:32:46Z.iso.sha256

@anmazzotti anmazzotti requested a review from a team as a code owner August 21, 2024 14:42
@anmazzotti anmazzotti self-assigned this Aug 21, 2024
@github-actions github-actions bot added area/operator operator related changes area/tests test related changes labels Aug 21, 2024
Copy link
Contributor

@ldevulder ldevulder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Andrea Mazzotti <[email protected]>
@anmazzotti anmazzotti merged commit 0899ba2 into rancher:main Aug 22, 2024
22 checks passed
anmazzotti added a commit to anmazzotti/elemental-operator that referenced this pull request Aug 22, 2024
anmazzotti added a commit that referenced this pull request Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/operator operator related changes area/tests test related changes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants