Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in Extensions workflows test outputs #13079

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Typo in Extensions workflows test outputs #13079

merged 1 commit into from
Jan 13, 2025

Conversation

jordojordo
Copy link
Member

@jordojordo jordojordo commented Jan 13, 2025 •
edited
Loading

Summary

Fixes #

There was a small typo in the variable we were referencing in the outputs. This will ensure we are using the same EXTENSION_TAG variable everywhere in these workflows rather than EXTENSIONS_TAG.

Occurred changes and/or fixed issues

Technical notes summary

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@jordojordo jordojordo requested a review from aalves08 January 13, 2025 16:37
@jordojordo jordojordo self-assigned this Jan 13, 2025
@jordojordo jordojordo added area/extensions QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this QA/None and removed QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this labels Jan 13, 2025
@jordojordo jordojordo added this to the v2.11.0 milestone Jan 13, 2025
aalves08
aalves08 approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@aalves08 aalves08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's get this in before midnight my time so that it runs 🙏

@jordojordo jordojordo merged commit fdc25a9 into rancher:master Jan 13, 2025
40 of 48 checks passed
@jordojordo jordojordo deleted the ext-test-workflows branch January 13, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aalves08 aalves08 aalves08 approved these changes

Assignees

@jordojordo jordojordo

Labels
area/extensions QA/None
Projects
None yet
Milestone
v2.11.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jordojordo @aalves08