Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling feature for cluster repositories #12984

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

momesgin
Copy link
Member

@momesgin momesgin commented Jan 6, 2025

Summary

Fixes #12485

Occurred changes and/or fixed issues

Changes on the Repositories page:

  • New action item for disabling/enabling is added to the menu and the bulkable action buttons
  • A disabled state is displayed when a repo is disabled, no changes for enabled state
  • Refresh action gets removed from the action items when a repo is disabled
Screenshot 2025-01-06 at 9 41 54 AM Screenshot 2025-01-06 at 9 42 09 AM image

Changes on the Charts page:

  • The disabled repository is removed from the dropdown list
Screenshot 2025-01-06 at 9 59 37 AM

Changes on the Installed Apps page:

  • Since the disabled repos are now filtered from the list of the repos, no available versions will be checked from the disabled repos in order to recommend for an update
Screenshot 2025-01-06 at 10 01 22 AM

Technical notes summary

The main change is filtering the disabled repos on the store level.

Areas or cases that should be tested

E2E tests are added to test this change on Repositories and Charts pages, but a manual test is needed to cover the upgrade case on the Installed Apps page.

Areas which could experience regressions

Shouldn't cause any regressions, hopefully.

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@momesgin momesgin added this to the v2.11.0 milestone Jan 6, 2025
@momesgin momesgin self-assigned this Jan 6, 2025
@momesgin
Copy link
Member Author

momesgin commented Jan 6, 2025

@kwwii @edenhernandez-suse please let me know what you think about these new changes

@edenhernandez-suse
Copy link

edenhernandez-suse commented Jan 16, 2025

As we discussed, the badge is not a disabled component, but a regular badge that informs about a disabled state, so let's use a neutral styling instead of the disabled styling:

Context

@momesgin momesgin changed the title Adding disable/enable functionality to cluster repos Disabling feature for cluster repositories Jan 24, 2025
@momesgin momesgin requested a review from jordojordo January 24, 2025 22:59
@momesgin momesgin marked this pull request as ready for review January 24, 2025 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for enabling/disabling Helm Repositories
2 participants