-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disabling feature for cluster repositories #12984
Open
momesgin
wants to merge
10
commits into
rancher:master
Choose a base branch
from
momesgin:12485-repositories-disabling-feature
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Disabling feature for cluster repositories #12984
momesgin
wants to merge
10
commits into
rancher:master
from
momesgin:12485-repositories-disabling-feature
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@kwwii @edenhernandez-suse please let me know what you think about these new changes |
…sitories-disabling-feature
…sitories-disabling-feature
momesgin
changed the title
Adding disable/enable functionality to cluster repos
Disabling feature for cluster repositories
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #12485
Occurred changes and/or fixed issues
Changes on the Repositories page:
Changes on the Charts page:
Changes on the Installed Apps page:
Technical notes summary
The main change is filtering the disabled repos on the store level.
Areas or cases that should be tested
E2E tests are added to test this change on Repositories and Charts pages, but a manual test is needed to cover the upgrade case on the Installed Apps page.
Areas which could experience regressions
Shouldn't cause any regressions, hopefully.
Checklist