Deprecate infrastructure ref #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkaempf
added
kind/enhancement
kind/bug
anmazzotti
force-pushed
the
deprecate_infrastructure_ref
branch
4 times, most recently
from
d6c1173 to
2f60670
Compare
4 tasks
anmazzotti
force-pushed
the
deprecate_infrastructure_ref
branch
5 times, most recently
from
f41db9c to
384b0dc
Compare
anmazzotti
force-pushed
the
deprecate_infrastructure_ref
branch
3 times, most recently
from
1d66023 to
4fe19da
Compare
|
@anmazzotti looks like this needs a rebase |
anmazzotti
force-pushed
the
deprecate_infrastructure_ref
branch
from
4fe19da to
37dcf28
Compare
anmazzotti
force-pushed
the
deprecate_infrastructure_ref
branch
2 times, most recently
from
5337d86 to
e21a208
Compare
|
@anmazzotti I am afraid this PR needs a rebase |
anmazzotti
force-pushed
the
deprecate_infrastructure_ref
branch
from
e21a208 to
69c3c74
Compare
anmazzotti
dismissed stale reviews from furkatgofurov7 and Danil-Grigorev
via
edca0ee
anmazzotti
force-pushed
the
deprecate_infrastructure_ref
branch
from
69c3c74 to
edca0ee
Compare
salasberryfin
previously approved these changes
Jan 10, 2025
anmazzotti
force-pushed
the
deprecate_infrastructure_ref
branch
from
edca0ee to
be6e69a
Compare
Danil-Grigorev
previously approved these changes
Jan 10, 2025
Signed-off-by: Andrea Mazzotti <[email protected]>
anmazzotti
force-pushed
the
deprecate_infrastructure_ref
branch
from
be6e69a to
baaec2c
Compare
furkatgofurov7
approved these changes
Jan 10, 2025
Danil-Grigorev
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kind/feature
kind/bug
What this PR does / why we need it:
This is a (dirty) attempt of using the v1beta1 newly added
RKE2ControlPlane.Spec.MachineTemplateand fixes the API to be used properly with ClusterClass.Note that this counts as an API change, however this is an attempt of getting away with it without a version bump.
The controlplane controller tries to catch and patch all missed conversions for this reason.
Also note that this PR assumes that v1beta1
RKE2ControlPlane.Spec.MachineTemplate.InfrastructureRefandRKE2ControlPlane.Spec.InfrastructureRefare equal. However since the former is currently ignored, it is not guaranteed that they will match.All test manifests have been kept the same to validate the quicky code, with the exception of the clusterclass since we want to make usage of the
machineTemplatefield.All other examples have been update to the
RKE2ControlPlane.Spec.MachineTemplatenotation.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #341
Special notes for your reviewer:
Checklist: