Overwrite files with format: ignition #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alexander-demicev @furkatgofurov7 - this is passing CI and ready for review, when you get a moment please take a look - thanks! |
furkatgofurov7
approved these changes
Aug 22, 2024
|
Thanks @hardys for the fix! |
alexander-demicev
approved these changes
Aug 22, 2024
|
@hardys CI requires all commits to be signed before merging the PRs, can you please push it signed? Thanks. |
auto-merge was automatically disabled
August 23, 2024 08:04
Head branch was pushed to by a user without write access
Now done, thanks! |
alexander-demicev
approved these changes
Aug 23, 2024
This aligns with the default cloud-init behavior and enables e.g overwriting distro-default files via RKE2ConfigTemplate using the spec.template.spec.files API. Signed-off-by: Steven Hardy <[email protected]>
auto-merge was automatically disabled
August 23, 2024 10:37
Head branch was pushed to by a user without write access
|
Sorry I misunderstood the signing requirement initially - commit should now be signed/verified https://github.com/rancher/cluster-api-provider-rke2/pull/411/commits |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aligns with the default cloud-init behavior and enables e.g overwriting distro-default files via RKE2ConfigTemplate using the spec.template.spec.files API.
With this we can see the example mentioned in #410 now works as expected the empty
/etc/motdis overwritten.kind/bug
Fixes #410