-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PowerBI map for TCEI #483
PowerBI map for TCEI #483
Conversation
Your demo site is ready! 🚀 Visit it here: https://ramp4-pcar4.github.io/story-ramp/powerbi-map/#/en/00000000-0000-0000-0000-000000000000 |
It looks like this explicitly doesn't teleport the grid on mobile, is that right? |
Yes I wasn't sure what we wanted for mobile so I just disabled teleport there for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found a couple of minor issues, but if we want this in the demo for tomorrow we can merge this in and spin up a new issue.
- The grid doesn't seem to open at all in mobile. If we're not showing it next to the map, maybe it should still open within?
- This one is super minor and likely not that important, but the teleported grid gets much thinner if you open the product in a normal window, resize it to mobile, and then resize it back. I'm currently working on a fix for all of the existing resizing issues in the app so this may fix itself when I publish that.
Reviewed 5 of 5 files at r1.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @yileifeng)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The grid opens for me on mobile? If there's a way to reproduce this we can throw both these points in a new issue if we want changes in for demo today
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @yileifeng)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah it seems to only occur if you load the product with a normal window size and then resize it to mobile afterwards. If the app is loaded while already in mobile mode then it works fine.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @yileifeng)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @yileifeng)
Related Item(s)
https://github.com/ramp4-pcar4/tcei-tmx-cwa-storylines/issues/8
Changes
Notes
Some methods could be improved upon and may be a bit hacky but mostly just for PoC. Used a merge grid to keep grid open which is probably not the best solution. Also, since there was only sample data in Excel format I could only add this as a CSV file layer and define a custom renderer to replicate expected behavior in issue.
Testing
Test first map panel in 0000 test product.
This change is