Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option 1: Use alternate way to incorporate CDTS #470

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

mohsin-r
Copy link
Member

@mohsin-r mohsin-r commented Sep 16, 2024

Closes #469

Changes

  • Updated CDTS to version 5.0.2.
  • Used alternate way to incorporate CDTS to remove the soyutils.js file.
  • Removed the static CDTS files as they didn't appear to be doing anything.

Testing

  1. Go to https://ramp4-pcar4.github.io/story-ramp/cdts/index-ca-en.html#/en/00000000-0000-0000-0000-000000000000 and https://ramp4-pcar4.github.io/story-ramp/cdts/index-ca-fr.html#/fr/00000000-0000-0000-0000-000000000000
  2. Ensure that everything (including the WET template stuff) is respectful.

This change is Reviewable

Copy link

Your demo site is ready! 🚀 Visit it here: https://ramp4-pcar4.github.io/story-ramp/cdts/#/en/00000000-0000-0000-0000-000000000000

@spencerwahl
Copy link
Member

spencerwahl commented Sep 16, 2024

image

looks like a possible css clash? second slide on https://ramp4-pcar4.github.io/story-ramp/cdts/index-ca-en.html#/en/00000000-0000-0000-0000-000000000000

Nevermind, this is the same on main

Copy link
Member

@spencerwahl spencerwahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @mohsin-r)

@mohsin-r mohsin-r changed the title Use alternate way to incorporate CDTS Option 1: Use alternate way to incorporate CDTS Sep 16, 2024
Copy link
Member

@szczz szczz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested both options side by side and noticed no differences.

I'm good with either option.

Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @mohsin-r)

Copy link
Member

@RyanCoulsonCA RyanCoulsonCA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @mohsin-r)

@mohsin-r
Copy link
Member Author

Rebased.

Copy link
Member

@szczz szczz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @mohsin-r)

@szczz szczz merged commit e693a4d into ramp4-pcar4:main Sep 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to the latest version of CDTS
4 participants