readability

rajatjindal · Aug 14, 2021 · 218cede · 218cede
1 parent 2b36e22
commit 218cede
Showing 1 changed file with 8 additions and 7 deletions.
diff --git a/pkg/editor/editor.go b/pkg/editor/editor.go
@@ -9,14 +9,15 @@ import (
 const defaultEditor = "vi"
 
 func getEditor() string {
-	editorFromEnv := os.Getenv("KUBE_EDITOR")
-	if editorFromEnv == "" {
-		editorFromEnv = os.Getenv("EDITOR")
-		if editorFromEnv == "" {
-			editorFromEnv = defaultEditor
-		}
+	if os.Getenv("KUBE_EDITOR") != "" {
+		return os.Getenv("KUBE_EDITOR")
 	}
-	return editorFromEnv
+
+	if os.Getenv("EDITOR") != "" {
+		return os.Getenv("EDITOR")
+	}
+
+	return defaultEditor
 }
 
 //Edit opens the editor