Added functionality for multiple pods and labels #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
rajatjindal
reviewed
Sep 25, 2021
|
|
||
| if len(o.args) > 0 { | ||
| o.podName = o.args[0] | ||
| if len(args) == 0 { |
There was a problem hiding this comment.
will this work for following:
kubectl-evict-pod --label a=b
There was a problem hiding this comment.
in that case len(args) will be 0 right?
|
taking a stab at making this better ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted a way to quickly double check / demonstrate the functionality of pod disruption budgets, so I added functionality to specify labels as an argument, e.g.:
kubectl evict-pod --label my-label-key=my-label-valueOn top of this, I turned the variable
podNameinto a slice of strings, so you can evicting multiple pods if you wish to, e.g.:kubectl evict-pod thing-one-6d5bfbb748-7vn6m thing-two-8d93ka03ka-d783m