Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cache@v4 and save-always option #40

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kruszczynski
Copy link

Cheers lovely people of rainforest!

TLDR

Use github's cache action and it's save-always option instead of a fork that still uses node 16.

Long story

So I noticed a Node 16 warning when running my RF suite
Screenshot 2024-06-14 at 17 10 33

I checked out always-upload-cache action but it seems neglected. I started looking into Github's cache action issue linked in its README and noticed that the v4 Changelog mentions a save-always option.

While it's not documented a quick peek the code suggests it does exactly what always-upload-cache does.

I haven't tested that yet, I'm planning to test in next week on my suite.

Use github's cache action and it's `save-always` option instead of a
fork that still uses node 16.
@magni-
Copy link
Contributor

magni- commented Jun 18, 2024

Looks like that save-always parameter doesn't actually work in practice 😞 actions/cache#1315

@kruszczynski
Copy link
Author

Shoot, nice catch @magni-

I'll take a stab at the suggested solution from that issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants