fix: excessive cpu usage from avatar component #1609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
1 task
magiziz
commented
Nov 13, 2023
| @@ -45,7 +45,7 @@ export function Avatar({ address, imageUrl, loading, size }: AvatarProps) { | |||
| > | |||
| <AvatarComponent address={address} ensImage={imageUrl} size={size} /> | |||
| </Box> | |||
| {typeof loading === 'boolean' && ( | |||
| {loading && ( | |||
There was a problem hiding this comment.
Make sure to only show the spinner if it's true. Since typeof loading === 'boolean' will always be true because it had false all the time.
nickbytes
approved these changes
Nov 13, 2023
nickbytes
reviewed
Nov 13, 2023
| <Box | ||
| color="accentColor" | ||
| display="flex" | ||
| height="full" | ||
| position="absolute" | ||
| style={{ |
There was a problem hiding this comment.
You need to add these styles back, or no?
There was a problem hiding this comment.
Ah yeah. They are not needed anymore since they are only used for transition effects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to this issue: #934