-
Notifications
You must be signed in to change notification settings - Fork 638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nfts + Create Query Store #6415
Open
derHowie
wants to merge
9
commits into
develop
Choose a base branch
from
@chris/nft-create-query-store
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunobar79
added
release
for release blockers and release candidate branches
and removed
release
for release blockers and release candidate branches
labels
Jan 23, 2025
derHowie
force-pushed
the
@chris/nft-create-query-store
branch
from
January 24, 2025 17:32
ce8ea38
to
727fd6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes APP-2250
What changed (plus any additional context for devs)
This PR moves 2 of our NFT hooks to
useQueryStore
in order to lay the groundwork for additional NFT perf improvements. Functionality should not change.Screen recordings / screenshots
https://www.loom.com/share/faae395b804847aa8691eb907358f753
What to test
Make sure NFTs is behaving appropriately