Add body and headers to request.active_resource
#413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanpdoyle
force-pushed
the
notification-payload
branch
from
1770501 to
c8bb71c
Compare
Closes rails#391 Expand the data broadcast by the `request.active_resource` Active Support Notification instrumentation event. For `GET` and `OPTION` requests, omit the `:body` value from the payload. For all other requests, include the `:body`.
seanpdoyle
force-pushed
the
notification-payload
branch
from
c8bb71c to
10204e9
Compare
seanpdoyle
commented
Jan 5, 2025
| assert_equal "http://37s.sunrise.i:3000/people.json?name=Matz", payload[:request_uri] | ||
| assert_equal({ "Accept" => "application/json" }, payload[:headers]) | ||
| assert_nil payload[:body] | ||
| assert_kind_of ActiveResource::Response, payload[:result] |
There was a problem hiding this comment.
This assertion is a quirk of how ActiveResource::HttpMock.respond_to works. In reality, the payload[:result] kind is a Net::HTTPResponse, but in the test harness it's an ActiveResource::Response.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #391
Expand the data broadcast by the
request.active_resourceActive Support Notification instrumentation event.For
GETandOPTIONrequests, omit the:bodyvalue from the payload. For all other requests, include the:body.