Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADD: initial unittest for agentneo.py file #92

Closed
wants to merge 26 commits into from
Closed

ADD: initial unittest for agentneo.py file #92

wants to merge 26 commits into from

Conversation

01PrathamS
Copy link
Contributor

@01PrathamS 01PrathamS commented Nov 11, 2024 •
edited
Loading

Description

  • Initial commit for unit tests in AgentNeo/agentneo.py.
  • Adds tests for project creation, project connection, project listing, and dashboard launch functionalities.
  • Updated requirements.txt with pytest for testing support.

Related Issue

Type of Change

  • Added unit tests for AgentNeo/agentneo.py functionalities.
  • Updated requirements.txt with pytest.

How Has This Been Tested?

  • Ran the new test cases to verify successful creation, connection, and listing of projects.
  • Ensured tests handle cases where projects already exist without causing test failures.
  • Verified the dashboard launch functionality with mock.

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, especially in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my feature works as expected.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

Additional Context

  • Exception handling in tests ensures cases with pre-existing projects are managed without needing deletion.
  • Sample test output and debugging information available upon request.

Impact on Roadmap

  • Aligns with project goals to improve code reliability and maintainability through comprehensive testing.
  • Supports future feature integration by ensuring foundational tests are in place.

kiranscaria and others added 20 commits October 30, 2024 10:19
@kiranscaria
🐛 fix the z-index of the trable header in trace history
e3b5fda 
Signed-off-by: kiranscaria <[email protected]>
@kiranscaria
🐛 resolves AttributeError: type object 'Callable' has no attribute '_…
4e81920 
…abc_registry' on some environments, update python dependency to py3.9

Signed-off-by: kiranscaria <[email protected]>
@vijayc9
evaluation LLM calls tracked bugs removed
762b569
@vijayc9
resolved network calls bugs
9605ced
@vijayc9
Moved all the API calls to a single place
387e631
@vijayc9
Merge branch 'v1.2' of https://github.com/raga-ai-hub/AgentNeo into e…
7d954b3 
…valuation_calls
@vijayc9
merged evaluation_calls into v1.2
a5691b8
@kiranscaria
Merge pull request #89 from raga-ai-hub/evaluation_calls
e0111f2 
Fix trace.stop(), network calls bugs, organise API calls
@frazakram
added custom tools
ecae428
@frazakram
added crewai version in documentation
692566d
@vijayc9
overview page modified
8861b4f
@vijayc9
migration completed for overview page
16afa8b
@vijayc9
evaluation page migration done
a335563
@vijayc9
dropdown changed and execution graph changed to use api
054a50e
@vijayc9
databaseUtils file removed
613094f
@vijayc9
execution graph modified
1e792c8
@vijayc9
comment Update ExecutionGraph.css
6f106a4
@vijayc9
comment Update dashboard_server.py
4644f5d
@vijayc9
comment Update TracePerformanceComparison.tsx
686f1df
@vijayc9
comment Update ExecutionGraphNodes.tsx
6156b69
@01PrathamS
Copy link
Contributor Author

can you please review this @kiranscaria, help me over here if things need to be refactored Thanks!!

@kiranscaria
Merge pull request #91 from raga-ai-hub/api_migration
e36d769 
Api migration plus execution graph modification
@kiranscaria
Merge pull request #90 from frazakram/v1.2
ec0b08e 
Added custom tool
@kiranscaria kiranscaria self-requested a review November 12, 2024 11:27
kiranscaria
kiranscaria requested changes Nov 12, 2024
View reviewed changes
Copy link
Collaborator

@kiranscaria kiranscaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@01PrathamS The changes seem okay, but pls re-raise the PR against this branch: https://github.com/raga-ai-hub/AgentNeo/tree/v1.2

@01PrathamS
Copy link
Contributor Author

@kiranscaria does this works?

@kiranscaria
Copy link
Collaborator

@01PrathamS You will need to close this PR and raise a new PR against this branch: https://github.com/raga-ai-hub/AgentNeo/tree/v1.2

pakhale-2012 pushed a commit to aristotle-ai/RagaAI-Catalyst that referenced this pull request Jan 26, 2025
@kiranscaria
Merge pull request raga-ai-hub#92 from aristotle-ai/custom_warning
7e4f9a3 
custom_warning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiranscaria kiranscaria kiranscaria requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@01PrathamS @kiranscaria @vijayc9 @frazakram @rehan-ai