REQUEST: Pull my changes to make this more "heroku friendly" #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi.
I make a few tweaks to this app to make it more Heroku friendly. The README explicitly shows how to clone it and then redeploy to heroku, using config vars instead of hard-code Facebook credentials. (I tweaked the code accordingly).
This app did not work on the bamboo-mri-1.9.2 stack, but it did work on bamboo-ree-1.8.7. I made that explicit in the README.
I still could not get either your version or my version to work as a canvas app, nor could I get it to work as on Ruby 1.9.2. Maybe later.
Please let me know what you do. This is my first fork and github push and pull request. This is really cool.
Cheers, Jay