Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move app/signing into factors/signatures-collector #359

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

micbakos-rdx
Copy link
Contributor

@micbakos-rdx micbakos-rdx commented Jan 28, 2025

Signing crate includes signatures-collector . It could be inside factors instead of app as is keys-collector, since it is an internal api.

Created a separate PR not to litter any other PR with many changes.

@micbakos-rdx micbakos-rdx added the Rust 🦀 Changes in Rust Sargon label Jan 28, 2025
@micbakos-rdx micbakos-rdx self-assigned this Jan 28, 2025
Copy link
Contributor

@CyonAlexRDX CyonAlexRDX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - in future prefer bumping version after PR approval, makes review a bit easier :)

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.59%. Comparing base (9ca1867) to head (d3c707d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #359   +/-   ##
=======================================
  Coverage   92.59%   92.59%           
=======================================
  Files        1170     1170           
  Lines       26248    26248           
  Branches       81       81           
=======================================
  Hits        24305    24305           
  Misses       1932     1932           
  Partials       11       11           
Flag Coverage Δ
kotlin 97.73% <ø> (ø)
rust 92.20% <ø> (ø)
swift 93.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@micbakos-rdx micbakos-rdx merged commit 860b5f2 into main Jan 28, 2025
13 checks passed
@micbakos-rdx micbakos-rdx deleted the mib/move-crates branch January 28, 2025 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Rust 🦀 Changes in Rust Sargon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants