Removing remaining references to radapp.dev #1604
Open
+18
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ytimocin <[email protected]>
ytimocin
force-pushed
the
ytimocin/rmRadAppDevRefs
branch
from
9c90f5a
to
a550b65
Compare
ytimocin
commented
Jul 13, 2024
|
|
||
| <img src="images/backend.png" alt="A diagram of the backend order processing service" width=600 /> | ||
|
|
||
| ## Routes | ||
|
|
||
| Radius offers communication between services via [Routes](https://docs.radapp.dev/concepts/appmodel-concept/#routes). | ||
| Radius offers communication between services via [Routes](https://docs.radapp.io/guides/author-apps/networking/overview/). |
There was a problem hiding this comment.
Couldn't find the corresponding page in radapp.io.
There was a problem hiding this comment.
We removed routes support. this needs to be removed
samples/dapr/README.md
Outdated
|
|
||
| ### Dapr service invocation | ||
|
|
||
| In this quickstart we will be using a [Dapr HTTP invoke route](https://docs.radapp.dev/reference/resource-schema/link-schema/dapr-schema/http/) resource to model communication from `frontend` to `backend`. This allows `frontend` to use Dapr service invocation to interact with `backend`. | ||
| In this quickstart we will be using a [Dapr HTTP invoke route](https://docs.radapp.io/reference/resource-schema/dapr-schema//) resource to model communication from `frontend` to `backend`. This allows `frontend` to use Dapr service invocation to interact with `backend`. |
There was a problem hiding this comment.
Couldn't find the corresponding page in radapp.io.
| @@ -1,6 +1,6 @@ | |||
| # eShop on Dapr reference application | |||
|
|
|||
| Visit the [Radius docs](https://radapp.dev/getting-started/reference-apps/eshop-dapr/) to learn more. | |||
| Visit the [Radius docs](https://docs.radapp.io/tutorials/eshop/) to learn more. | |||
There was a problem hiding this comment.
Couldn't find the corresponding page in radapp.io.
There was a problem hiding this comment.
eshop-dapr refernce app is available only in samples repo and not in our docs...may be we can link that here
Reshrahim
requested changes
Jul 16, 2024
There was a problem hiding this comment.
Thank you Yetkin for catching this. Looks like we missed to do this clean up. I think the page needs some additional changes to match the existing content here -https://docs.radapp.io/tutorials/dapr/
|
|
||
| <img src="images/backend.png" alt="A diagram of the backend order processing service" width=600 /> | ||
|
|
||
| ## Routes | ||
|
|
||
| Radius offers communication between services via [Routes](https://docs.radapp.dev/concepts/appmodel-concept/#routes). | ||
| Radius offers communication between services via [Routes](https://docs.radapp.io/guides/author-apps/networking/overview/). |
There was a problem hiding this comment.
We removed routes support. this needs to be removed
|
|
||
| ### Dapr service invocation | ||
|
|
||
| In this quickstart we will be using a [Dapr HTTP invoke route](https://docs.radapp.dev/reference/resource-schema/link-schema/dapr-schema/http/) resource to model communication from `frontend` to `backend`. This allows `frontend` to use Dapr service invocation to interact with `backend`. | ||
| In this quickstart we will be using a [Dapr HTTP invoke route](https://docs.radapp.io/reference/resource-schema/dapr-schema/) resource to model communication from `frontend` to `backend`. This allows `frontend` to use Dapr service invocation to interact with `backend`. | ||
|
|
||
| <img src="images/invoke.png" alt="A diagram of the Dapr service invocation" width=500 /> |
There was a problem hiding this comment.
none of the images get rendered as there is no images folder. would be good to remove these code inserts
|
|
||
| ### Dapr service invocation | ||
|
|
||
| In this quickstart we will be using a [Dapr HTTP invoke route](https://docs.radapp.dev/reference/resource-schema/link-schema/dapr-schema/http/) resource to model communication from `frontend` to `backend`. This allows `frontend` to use Dapr service invocation to interact with `backend`. | ||
| In this quickstart we will be using a [Dapr HTTP invoke route](https://docs.radapp.io/reference/resource-schema/dapr-schema/) resource to model communication from `frontend` to `backend`. This allows `frontend` to use Dapr service invocation to interact with `backend`. | ||
|
|
||
| <img src="images/invoke.png" alt="A diagram of the Dapr service invocation" width=500 /> | ||
|
|
||
| ## Link |
There was a problem hiding this comment.
we need to update these as well..not links anymore
| @@ -1,6 +1,6 @@ | |||
| # eShop on Dapr reference application | |||
|
|
|||
| Visit the [Radius docs](https://radapp.dev/getting-started/reference-apps/eshop-dapr/) to learn more. | |||
| Visit the [Radius docs](https://docs.radapp.io/tutorials/eshop/) to learn more. | |||
There was a problem hiding this comment.
eshop-dapr refernce app is available only in samples repo and not in our docs...may be we can link that here
Co-authored-by: Reshma Abdul Rahim <[email protected]> Signed-off-by: Yetkin Timocin <[email protected]>
Co-authored-by: Reshma Abdul Rahim <[email protected]> Signed-off-by: Yetkin Timocin <[email protected]>
Co-authored-by: Reshma Abdul Rahim <[email protected]> Signed-off-by: Yetkin Timocin <[email protected]>
Co-authored-by: Reshma Abdul Rahim <[email protected]> Signed-off-by: Yetkin Timocin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing remaining references to radapp.dev. Some links that I updated may be wrong. Need a second eye. cc/ @willtsai @Reshrahim