Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup bicepconfig #8012

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Conversation

sk593
Copy link
Contributor

@sk593 sk593 commented Oct 22, 2024

Description

Some experimental features in the bicepconfig were consolidated in the Bicep repo: Azure/bicep#14944. This PR removes the unnecessary features.

Type of change

  • This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

Fixes: #issue_number

Contributor checklist

Please verify that the PR meets the following requirements, where applicable:

Signed-off-by: sk593 <[email protected]>
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.33%. Comparing base (ab67487) to head (6e7a2de).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8012   +/-   ##
=======================================
  Coverage   59.32%   59.33%           
=======================================
  Files         560      560           
  Lines       37487    37487           
=======================================
+ Hits        22241    22244    +3     
+ Misses      13699    13697    -2     
+ Partials     1547     1546    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sk593 sk593 changed the title [wip] Cleanup bicepconfig Cleanup bicepconfig Oct 23, 2024
@sk593 sk593 marked this pull request as ready for review October 23, 2024 17:05
@sk593 sk593 requested review from a team as code owners October 23, 2024 17:05
@radius-functional-tests
Copy link

radius-functional-tests bot commented Oct 23, 2024

Radius functional test overview

🔍 Go to test action run

Name Value
Repository sk593/radius
Commit ref 6e7a2de
Unique ID func1065b55e8d
Image tag pr-func1065b55e8d
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr: 1.12.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func1065b55e8d
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func1065b55e8d
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func1065b55e8d
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func1065b55e8d
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

@lakshmimsft lakshmimsft merged commit dd86d60 into radius-project:main Oct 23, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants