Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update devcontainer publishing path #6967

Merged
merged 2 commits into from
Dec 18, 2023
Merged

Conversation

rynowak
Copy link
Contributor

@rynowak rynowak commented Dec 18, 2023

Description

This updates the devcontainer publishing path to (hopefully):

ghcr.io/radius-project/devcontainer-features/radcli:latest

This matches the container that everyone seems to be following at: https://containers.dev/collections

In particular I don't want the repo name to be part of the path, because we will probably change repos in the future.

Type of change

  • This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

Part of: #6923

Auto-generated summary

copilot:all

This updates the devcontainer publishing path to (hopefully):

```
ghcr.io/radius-project/devcontainer-features/radcli:latest
```

This matches the container that everyone seems to be following at: https://containers.dev/collections

In particular I don't want the repo name to be part of the path, because we will probably change repos in the future.

Signed-off-by: Ryan Nowak <[email protected]>
@rynowak rynowak requested review from a team as code owners December 18, 2023 17:41
@rynowak
Copy link
Contributor Author

rynowak commented Dec 18, 2023

@lechnerc77 can you take a look? This should just be changing the path.

Copy link

github-actions bot commented Dec 18, 2023

Test Results

3 038 tests  ±0   3 028 ✔️ ±0   3m 26s ⏱️ ±0s
   260 suites ±0        10 💤 ±0 
       1 files   ±0          0 ±0 

Results for commit e949db5. ± Comparison against base commit 5a53736.

♻️ This comment has been updated with latest results.

Copy link

65.5

For the detailed report, please go to Checks tab, click Build and Test, and then download unit_test_coverage artifact at the bottom of build page.

  • Your PR branch coverage: 65.5 %
  • main branch coverage: 65.5 %
  • diff coverage: 0 %

The coverage result does not include the functional test coverage.

@lechnerc77
Copy link
Contributor

lechnerc77 commented Dec 18, 2023

@lechnerc77 can you take a look? This should just be changing the path.

@rynowak changes look good. The added option in the GH workflow should do the trick and replace the path as you are aiming for. The other replacements are consisten with that.

@radius-functional-tests
Copy link

radius-functional-tests bot commented Dec 18, 2023

Radius functional test overview

🔍 Go to test action run

Name Value
Repository radius-project/radius
Commit ref 0ea42a8
Unique ID 2dd93f4e89
Image tag pr-2dd93f4e89
Click here to see the list of tools in the current test run
  • gotestsum 1.10.0
  • KinD: v0.20.0
  • Dapr: 1.12.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.1.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/functional/shared/recipes/<name>:pr-2dd93f4e89
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-2dd93f4e89
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-2dd93f4e89
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-2dd93f4e89
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting samples functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting datastoresrp functional tests...
⌛ Starting ucp functional tests...
⌛ Starting shared functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting kubernetes functional tests...
✅ samples functional tests succeeded
✅ ucp functional tests succeeded
✅ kubernetes functional tests succeeded
✅ msgrp functional tests succeeded
✅ daprrp functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ shared functional tests succeeded

@@ -8,7 +8,7 @@ This will install the latest stable release of the `rad` CLI.

```json
"features": {
"ghcr.io/devcontainers/radius/radiuscli:latest": {
"ghcr.io/radius-project/devcontainer-features/radcli:latest": {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what the updated path will be. ghcr.io/radius-project/radius/radcli:latest is the current path.

@radius-functional-tests
Copy link

radius-functional-tests bot commented Dec 18, 2023

Radius functional test overview

🔍 Go to test action run

Name Value
Repository radius-project/radius
Commit ref e949db5
Unique ID bc1c6bf5aa
Image tag pr-bc1c6bf5aa
Click here to see the list of tools in the current test run
  • gotestsum 1.10.0
  • KinD: v0.20.0
  • Dapr: 1.12.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.1.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/functional/shared/recipes/<name>:pr-bc1c6bf5aa
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-bc1c6bf5aa
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-bc1c6bf5aa
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-bc1c6bf5aa
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting samples functional tests...
⌛ Starting datastoresrp functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting shared functional tests...
⌛ Starting kubernetes functional tests...
⌛ Starting ucp functional tests...
✅ samples functional tests succeeded
✅ kubernetes functional tests succeeded
✅ ucp functional tests succeeded
✅ msgrp functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ daprrp functional tests succeeded
✅ shared functional tests succeeded

Copy link

65.5

For the detailed report, please go to Checks tab, click Build and Test, and then download unit_test_coverage artifact at the bottom of build page.

  • Your PR branch coverage: 65.5 %
  • main branch coverage: 65.5 %
  • diff coverage: 0 %

The coverage result does not include the functional test coverage.

@rynowak rynowak merged commit 4eff028 into main Dec 18, 2023
22 checks passed
@rynowak rynowak deleted the rynowak/devcontainer-feature-path branch December 18, 2023 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants