Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove stale devcontainer #6931

Merged
merged 2 commits into from
Dec 7, 2023

Conversation

rynowak
Copy link
Contributor

@rynowak rynowak commented Dec 7, 2023

Description

This change removes our old outdated and unused devcontainer.

  • There's another devcontainer definition in our repo and it's much more useful for developing Radius.
  • There's another devcontainer definition in our samples repo that's useful for trying out Radius.

Part-of: #6923

  • This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

Auto-generated summary

🤖[deprecated] Generated by Copilot at b102f3f

Summary

📱🛠️🌐

Removed unused files related to tutorials-codespace from .devcontainer folder. These files were not needed for the radius project and were causing confusion and clutter.

is_valid checks
refactored for clarity
autumn leaves falling

Walkthrough

  • Remove files related to tutorials-codespace devcontainer (link, link, link, link)

@rynowak rynowak requested review from a team as code owners December 7, 2023 18:23
Part-of: radius-project#6923

This change removes our **old** **outdated** and **unused** devcontainer.

- There's another devcontainer definition in our repo and it's much more useful for developing Radius.
- There's another devcontainer definition in our samples repo that's useful for trying out Radius.

Signed-off-by: Ryan Nowak <[email protected]>
@radius-functional-tests
Copy link

radius-functional-tests bot commented Dec 7, 2023

Radius functional test overview

🔍 Go to test action run

Name Value
Repository rynowak/radius
Commit ref a339130
Unique ID 1d709b7fd4
Image tag pr-1d709b7fd4
Click here to see the list of tools in the current test run
  • gotestsum 1.10.0
  • KinD: v0.20.0
  • Dapr: 1.12.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.1.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/functional/shared/recipes/<name>:pr-1d709b7fd4
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-1d709b7fd4
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-1d709b7fd4
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-1d709b7fd4
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting daprrp functional tests...
⌛ Starting ucp functional tests...
⌛ Starting samples functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting kubernetes functional tests...
⌛ Starting datastoresrp functional tests...
✅ ucp functional tests succeeded
✅ msgrp functional tests succeeded
✅ samples functional tests succeeded
✅ daprrp functional tests succeeded
✅ kubernetes functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ shared functional tests succeeded

@rynowak rynowak merged commit 1d265be into radius-project:main Dec 7, 2023
16 checks passed
@rynowak rynowak deleted the remove-stale-devcontainer branch December 7, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants