Remove broken signoff argument #1269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: willdavsmith <[email protected]>
sk593
reviewed
Nov 8, 2024
| @@ -79,4 +79,4 @@ jobs: | |||
| if: env.NO_CHANGES != 'true' | |||
| env: | |||
| GITHUB_TOKEN: ${{ secrets.GH_RAD_CI_BOT_PAT}} | |||
| run: gh pr create --title "Upmerge to edge" --body "Upmerge to edge (kicked off by @${{ github.triggering_actor }})" --base edge --head $BRANCH_NAME --signoff | |||
| run: gh pr create --title "Upmerge to edge" --body "Upmerge to edge (kicked off by @${{ github.triggering_actor }})" --base edge --head $BRANCH_NAME | |||
There was a problem hiding this comment.
We require commits to be signed off for PRs so wondering if this will remove the auto-signoff. It looks like the flag is meant to be used with git commit so we should update the workflow in edge to include that here:
docs/.github/workflows/upmerge.yaml
Line 67 in d425e1d
There was a problem hiding this comment.
I don't think this needs to block the release but we should make sure to update the workflow after or open an issue to track it
There was a problem hiding this comment.
agreed. BTW for reference the samples repo does not sign off commits today when we upmerge.
There was a problem hiding this comment.
oh interesting. if it doesn't mess with the PR checks, then there's no issue
There was a problem hiding this comment.
opened issues:
sk593
approved these changes
Nov 8, 2024
nithyatsu
approved these changes
Nov 8, 2024
Reshrahim
approved these changes
Nov 8, 2024
Reshrahim
added a commit
that referenced
this pull request
Nov 12, 2024
* Update docs for v0.39.0 * Add IRSA to the cloud provider table (#1262) * Update index.md Signed-off-by: Reshma Abdul Rahim <[email protected]> * Update index.md Signed-off-by: Reshma Abdul Rahim <[email protected]> --------- Signed-off-by: Reshma Abdul Rahim <[email protected]> * create CODEOWNERS (#1263) Signed-off-by: Will Tsai <[email protected]> * Update the supported clusters link in getting started guide (#1238) * Update docs for v0.38.0 * Update index.md Signed-off-by: Reshma Abdul Rahim <[email protected]> --------- Signed-off-by: Reshma Abdul Rahim <[email protected]> Co-authored-by: Radius CI Bot <[email protected]> * Remove broken signoff argument (#1269) Signed-off-by: willdavsmith <[email protected]> * Fix GH PAT scope (#1272) Signed-off-by: willdavsmith <[email protected]> * adding gh auth login (#1273) Signed-off-by: willdavsmith <[email protected]> * Fix gh auth login command (#1274) Signed-off-by: willdavsmith <[email protected]> * Fix GitHub auth login for upmerge workflow (#1278) * Adding GH_TOKEN Signed-off-by: willdavsmith <[email protected]> * Adding Signoff Signed-off-by: willdavsmith <[email protected]> * Removing Signoff Signed-off-by: willdavsmith <[email protected]> --------- Signed-off-by: willdavsmith <[email protected]> * Removing version info Signed-off-by: willdavsmith <[email protected]> --------- Signed-off-by: Reshma Abdul Rahim <[email protected]> Signed-off-by: Will Tsai <[email protected]> Signed-off-by: willdavsmith <[email protected]> Co-authored-by: Reshma Abdul Rahim <[email protected]> Co-authored-by: Will <[email protected]> Co-authored-by: Will Smith <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1268
Thank you for helping make the Radius documentation better!
Please follow this checklist before submitting:
In addition, please fill out the following to help reviewers understand this pull request:
Description
Issue reference