WIP: radicle-surf history #39
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fintan Halpenny <[email protected]>
keepsimple1
reviewed
Oct 25, 2022
There was a problem hiding this comment.
Thank you for sharing your ideas and code. I like your idea of defining History as an iterator (or produces an iterator for that matter). I felt we are on the same page at the high level. I made changes in my PR #37 with similar design, but also different in various aspects. I am OK with either moving forward using this PR or using my PR.
I will skip commenting on details here for now as the difference in my PR probably says things more clearly. I've also included an alternative design in the updated doc that might be worth considering as well. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the design document at #38, I decided to play around with the history formulation using a revwalk. It looks promising!
I wanted to see what the output would look like so I added a test that fails and run:
cargo test -p radicle-surf-test history