This repository has been archived by the owner on Dec 30, 2021. It is now read-only.
Make full titlebar draggable #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the "Sign in" screen, the title bar was only draggable right around the control buttons. I've widened the title bar so that you can click and drag on a much larger area.
The title bar does not extend all the way across because then it would cover up the right hand controls during sign in and general use.
Currently, during general use, the window dragging is somewhat slow. I think this is the drag coming from
ReactElectronWebview, but I can't be sure. Either way, this is more responsive.I'm not sure about the change in GooglePlayMusic, but it stopped an error from happening, didn't cause any new errors, and looks like it's what was intended. The console was complaining that it couldn't open
gpm.js, but it was happy about getting the built one from/dist/