Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

match new r2bin struct type #121

Merged
merged 3 commits into from
Aug 9, 2023
Merged

Conversation

lowlyw
Copy link
Contributor

@lowlyw lowlyw commented Aug 9, 2023

radareorg/radare2@4a75b94 renamed o to bo, follow that change so it builds

Checklist

  • Closing issues: #issue
  • Mark this if you consider it ready to merge
  • I've added tests (optional)
  • I wrote some documentation

Description

r_bin_file_t.o was renamed to r_bin_file_t.bo, follow this change so that it can build again.

radareorg/radare2@4a75b94 renamed `o` to `bo`, follow that change so it builds
@trufae
Copy link
Contributor

trufae commented Aug 9, 2023

Please wrap this change with an if to keep backward compat. Thanks!

@lowlyw
Copy link
Contributor Author

lowlyw commented Aug 9, 2023

what would the if be checking? when r2ghidra is built there's no -DVERSION=blah or anything, is there?

@lowlyw
Copy link
Contributor Author

lowlyw commented Aug 9, 2023

nvm, updated, should work now

@trufae
Copy link
Contributor

trufae commented Aug 9, 2023

Beautiful <3

@trufae trufae merged commit f5d17d2 into radareorg:master Aug 9, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants