Move development dependencies to Gemfile
#95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RuboCop recommends gem authors specify development dependencies in their project's `Gemfile` rather than in the gemspec. There's some debate on the PR (linked below) over the preference, but, in the spirit of leaning in to community defaults, this change moves those dependencies. Links: - https://docs.rubocop.org/rubocop/1.63/cops_gemspec.html#gemspecdevelopmentdependencies - rubocop/rubocop#11469
…removing `Gemspec/DevelopmentDependencies`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the project's development dependencies from its gemspec to
Gemfilefollowing RuboCop'sGemspec/DevelopmentDependencies(rubocop/rubocop#11469) recommendation. There's some debate on that PR over the change, but in the spirit of leaning in to community defaults, this change moves those dependencies.I'll admit to not knowing this project's maintainers well enough to know whether or not y'all prefer this particular recommendation. If it's undesirable, we can close this one out and/or move the rule's configuration from the todo file to the main
.rubocop.ymlfile.