Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide implementation of Cramer's V. #56

Closed
wants to merge 12 commits into from
Closed

Provide implementation of Cramer's V. #56

wants to merge 12 commits into from

Commits on Mar 29, 2016

  1. Provide implementation of Cramer's V. 

    Closes issue #52.
    @rnowling
    rnowling committed Mar 29, 2016
    Configuration menu
    Copy the full SHA
    7f54e3a View commit details
    Browse the repository at this point in the history

  2. Remove leftover commented-out line

    @rnowling
    rnowling committed Mar 29, 2016
    Configuration menu
    Copy the full SHA
    87788ff View commit details
    Browse the repository at this point in the history

  3. Move divide outside of loop. Yay distributive law!

    @rnowling
    rnowling committed Mar 29, 2016
    Configuration menu
    Copy the full SHA
    495a247 View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2016

  1. Address Erik's suggestions

    @rnowling
    rnowling committed Apr 7, 2016
    Configuration menu
    Copy the full SHA
    0ab8919 View commit details
    Browse the repository at this point in the history

  2. Replace redundant counting code with a function

    @rnowling
    rnowling committed Apr 7, 2016
    Configuration menu
    Copy the full SHA
    cb60324 View commit details
    Browse the repository at this point in the history

  3. Use required seed instead of optional RNG to make Scala 2.11 happy

    @rnowling
    rnowling committed Apr 7, 2016
    Configuration menu
    Copy the full SHA
    0ab8ea1 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2016

  1. Address some of Erik's comments

    @rnowling
    rnowling committed Apr 20, 2016
    Configuration menu
    Copy the full SHA
    c4d7af5 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2016

  1. Update Cramer's V permutation test name, test docs, move cross produc… 

    …t to utils, and add extra guard to Cramer's V.
    @rnowling
    rnowling committed May 2, 2016
    Configuration menu
    Copy the full SHA
    c2f0579 View commit details
    Browse the repository at this point in the history

  2. Use values instead of zipping

    @rnowling
    rnowling committed May 2, 2016
    Configuration menu
    Copy the full SHA
    9345c59 View commit details
    Browse the repository at this point in the history

  3. Updated tests, should have been in earlier commit

    @rnowling
    rnowling committed May 2, 2016
    Configuration menu
    Copy the full SHA
    efacb4c View commit details
    Browse the repository at this point in the history

  4. Use Random.nextLong instead of -1 for the default seed

    @rnowling
    rnowling committed May 2, 2016
    Configuration menu
    Copy the full SHA
    034351c View commit details
    Browse the repository at this point in the history

  5. pValueEstimate should return probability of higher association, not less

    @rnowling
    rnowling committed May 2, 2016
    Configuration menu
    Copy the full SHA
    3cd0bdd View commit details
    Browse the repository at this point in the history