Support Slurm 24.11 and REST API v0.0.40 #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rezib
force-pushed
the
pr/feat-366
branch
6 times, most recently
from
445445e to
40bc7ed
Compare
Remove unused fields from default filters of slurmrestd responses: - required on /slurm/*/jobs endpoint. - state_reason on, /slurm/*/job/<id> endpoint
Note dev/crawl-tests-assets has been modified to bump to Slurm REST API v0.0.40, and limit nodes dump to 100 nodes at maximum, and jobs dumps on agent and gateway to 100 jobs as well. The new API brings some changes: - The slurm key in meta hash of ping response is now lowercase, - Job state in now an array of states.
Bump [slurmrestd] > version default value from 0.0.39 to 0.0.40 in agent configuration for compatibility with Slurm 24.11.
Bump minimal required Slurm version in agent from 23.02.0 to 23.11.0.
In Slurm REST API v0.0.40, meta > slurm > version > {major,minor,micro}
are now strings, they must be converted to integers for version
comparaison.
The slurm key in meta object of Slurm REST API ping response is lowercase since v0.0.40.
Check metrics collector does not report unknown jobs/nodes/cores with tests assets.
When requesting not existing nodes, Slurm REST API v0.0.40 does not return empty nodes array anymore in the response. The error message has also slightly changed.
The job_state field of jobs in Slurm REST API 0.0.40 is now a list of states, rather than a simple string.
In dev/crawl-tests-assets script, try to read admin password from environment before prompting the user interactively. This makes possible to launch the script non-interactively.
Update ClusterJob and ClusterIndividualJob interfaces with all their inner objects to match new objects returned by Slurm REST API v0.0.40.
Adapt frontend code base to Slurm jobs job_state field type change from a string to an array of strings with Slurm REST API 0.0.40.
Update ClusterNode and ClusterIndividualNode interfaces with all their inner objects to match new objects returned by Slurm REST API v0.0.40.
Update ClusterQOS and ClusterReservation interfaces with all their inner objects to match new objects returned by Slurm REST API v0.0.40.
Adapt NodeView to the node boot_time and last_busy fields type change from number to ClusterOptionalNumber object.
Adapt ReservationsView to the reservation start_time and end_time fields type change from number to ClusterOptionalNumber object.
Mention requirement of Slurm >= 23.11 and dropped support of Slurm 23.02.
Update screenshots due to supported Slurm version changes.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pending tasks:
CHANGELOG.mdfix #366