Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change agent info fields parsing error message to reflect new response content #393

Merged
merged 2 commits into from
Nov 13, 2024
Merged

Change agent info fields parsing error message to reflect new response content #393

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
721d094
refactor(gateway): agent info parsing error msg
rezib Nov 13, 2024
7ba1bf7
tests(gateway): reflect error message change
rezib Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Add requirement on markdown external library for `gateway` extra package.

### Changed
- gateway: Change error message when unable to parse agent info fields.
- docs:
- Update configuration reference documentation.
- Update dashboard screenshot in overview page with example of resource chart.
Expand Down
2 changes: 1 addition & 1 deletion slurmweb/apps/gateway.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ def from_json(cls, url, data):
return cls(data["cluster"], data["infrastructure"], data["metrics"], url)
except KeyError as err:
raise SlurmwebAgentError(
"Unable to retrieve cluster name from agent"
"Unable to parse cluster info fields from agent"
) from err


Expand Down
4 changes: 2 additions & 2 deletions slurmweb/tests/test_gateway.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,8 @@ def test_agents_missing_key(self, mock_requests_get):
cm.output,
[
"ERROR:slurmweb.apps.gateway:Unable to retrieve agent info from url "
"http://localhost: [SlurmwebAgentError] Unable to retrieve cluster "
"name from agent"
"http://localhost: [SlurmwebAgentError] Unable to parse cluster info "
"fields from agent"
],
)

Expand Down
Loading