Fix AttributeError on requests.exception.JSONDecodeError
#392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following metrics boolean field addition in 15544df, update agent info asset to matchnew responses from agent.
rezib
added
the
bug
Catch generic requests.exceptions.RequestException on information retrieval from agents to avoid AttributeError with more specific exceptions on old versions on Requests library. fix #391
Catch JSONDecodeError from simpleson external library and json standard library module, with the logic required with Requests < 2.27.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mock_agent_responseandmock_prometheus_responsefix #391