Automated Resyntax fixes #716
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![resyntax-ci[bot]](https://avatars.githubusercontent.com/in/999945?s=60&v=4){kind=small}
Internal definitions are recommended instead of `let` expressions, to reduce nesting.
This expression can be replaced with a simpler, equivalent `hash-update!` expression.
These nested `for` loops can be replaced by a single `for*` loop.
This `if` expression can be refactored to an equivalent expression using `and`.
Use the `#:when` keyword instead of `when` to reduce loop body indentation.
This expression is equivalent to calling the `positive?` predicate.
rfindler
reviewed
Feb 2, 2025
| (let* ([pos-left (- (syntax-position stx) 1)] | ||
| [pos-right (+ pos-left (syntax-span stx))]) | ||
| (send defs-text | ||
| syncheck:add-jump-to-definition/phase-level+space |
There was a problem hiding this comment.
I think this isn't how we want to format send calls. I would prefer the method name be as it was before, on the same line as the send.
rfindler
reviewed
Feb 2, 2025
| ;; assume this is a binder, show uses | ||
| #;(when (and color? (zero? start)) | ||
| (color-unused-binder (list-ref key 0) (list-ref key 1) (list-ref key 2))) | ||
| [(zero? end) (show-starts)] |
There was a problem hiding this comment.
Something went wrong here. The code should behave the same but the comment went into the wrong place.
rfindler
reviewed
Feb 2, 2025
| (color-unused-binder (list-ref key 0) (list-ref key 1) (list-ref key 2))) | ||
| [(zero? end) (show-starts)] | ||
| ;; assume this is a use, show bindings (usually just one, so do nothing) | ||
| [(zero? start) (show-ends)] |
There was a problem hiding this comment.
same here, although this one is less wrong, I'd say.
|
Aside from the comments, this looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resyntax fixed 20 issues in 3 files.
let-to-definenested-for-to-for*if-else-false-to-andwhen-expression-in-for-loop-to-when-keywordhash-set!-ref-to-hash-update!zero-comparison-to-positive?