fix: fixed up ironic state workflow and document it and keystone workflow #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sensor didn't live in the correct namespace to be triggered by the eventbus. The eventbus for OpenStack lives in the the openstack namespace so the sensor needs to live there. The sensor also duplicated the workflow calling the steps directly and now it uses the workflow that we've created for triggering these updates. Added comments to explain how the sensor is working and how it's triggering.
Documented the keystone project workflow better based on the updates to the ironic one.
Remove this unused workflow.
|
cardoe
force-pushed
the
update-workflow-triggers
branch
from
938a089
to
350b183
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed up the ironic sensor and workflow to actually run on events while documenting it better. Added some documentation to the keystone one as well and sync its configuration.