feat: Have Enroll power on server and retry fetching LLDP info #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
November 13, 2024 14:14
stevekeay
changed the title
stevekeay
force-pushed
the
retry-chassis-lldp-info
branch
from
2cd7fab
to
bbb9589
Compare
skrobul
reviewed
Nov 13, 2024
stevekeay
force-pushed
the
retry-chassis-lldp-info
branch
from
cf66359
to
dec4b10
Compare
skrobul
approved these changes
Nov 14, 2024
skrobul
reviewed
Nov 14, 2024
|
|
||
| logger = setup_logger(__name__) | ||
|
|
||
| MIN_REQUIRED_NEIGHBOR_COUNT = 4 |
There was a problem hiding this comment.
sorry didn't notice this earlier - is this still used?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the server is powered off the network interfaces are down, so we don't get LLDP information.
Therefore, Enroll should power on the server, then wait for LLDP information to appear before continuing.