feat: [ACI-587, ACI-586] implement openedx origin badge progress completion processing #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrii-hantkovskyi
commented
Mar 20, 2024
andrii-hantkovskyi
commented
- Demo
added 2 commits
March 20, 2024 17:46
andrii-hantkovskyi
force-pushed
the
hantkovskyi/aci-587/badge-progress-completion-signal
branch
from
934ae9c to
e29cd46
Compare
wowkalucky
approved these changes
Mar 26, 2024
| return | ||
|
|
||
| if badge_template.origin == 'openedx': |
There was a problem hiding this comment.
Note for future: here we'd want to make badge templates to be responsible for their type of user credentials:
badge_template.award(username)
badge_template.revoke(username)
- each badge template type (with a specific origin) manages its type of user credential;
| badge_template = get_badge_template_by_id(badge_template_id) | ||
|
|
||
| if badge_template is None: |
There was a problem hiding this comment.
This should possibly log an error.
wowkalucky
deleted the
hantkovskyi/aci-587/badge-progress-completion-signal
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.