refactor: [ACI-956] little code cleanup #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrii-hantkovskyi
commented
Apr 26, 2024
andrii-hantkovskyi
commented
- remove unused imports, variables
- add missing docstrings
- add & fix tests
added 2 commits
April 26, 2024 19:49
- remove unused imports, variables - add missing docstrings - add & fix tests
wowkalucky
requested changes
Apr 30, 2024
| @@ -139,3 +221,4 @@ def test_get_event_type_keypaths(self): | |||
|
|
|||
| for excluded_keypath in settings.BADGES_CONFIG.get("EXCLUDED_KEY_PATHS", []): | |||
| self.assertNotIn(excluded_keypath, event_type_keypaths) | |||
| >>>>>>> aci.main | |||
There was a problem hiding this comment.
@andrii-hantkovskyi unresolved conflict!
andrii-hantkovskyi
force-pushed
the
hantkovskyi/aci-956/overall-code-check
branch
from
5e99b0e to
7431cdd
Compare
wowkalucky
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.