Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [ACI-560] conditionally enable badge events basing on main feature flag #133

Merged
merged 6 commits into from
Apr 22, 2024
Merged

feat: [ACI-560] conditionally enable badge events basing on main feature flag #133

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0ea0281
feat: [ACI-560] conditionally enable badge events basing on main feat…
Apr 12, 2024
9f525f2
fix: [ACI-560] correct should_sent func according to edx-platform
Apr 12, 2024
1c12ab2
fix: [ACI-560] add func call to get bool value for check
Apr 12, 2024
6315a84
fix: [ACI-560] use implemented func for check
Apr 12, 2024
d3ca43d
feat: [ACI-560] implement BADGES_ENABLED seeting
Apr 19, 2024
e49cb8a
refacotr: [ACI-560] hardcode BADGES_ENABLED to True
Apr 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions credentials/settings/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -543,6 +543,9 @@
FAVICON_URL = "https://edx-cdn.org/v3/default/favicon.ico"
LOGO_POWERED_BY_OPEN_EDX_URL = "https://edx-cdn.org/v3/prod/open-edx-tag.svg"

# Badges settings
BADGES_ENABLED = True

# Event Bus Settings
EVENT_BUS_PRODUCER = "edx_event_bus_redis.create_producer"
EVENT_BUS_CONSUMER = "edx_event_bus_redis.RedisEventConsumer"
Expand All @@ -560,7 +563,7 @@
# .. toggle_warning: The default may be changed in a later release.
# .. toggle_use_cases: opt_in
"org.openedx.learning.badge.awarded.v1": {
"learning-badges-lifecycle": {"event_key_field": "badge.uuid", "enabled": True},
"learning-badges-lifecycle": {"event_key_field": "badge.uuid", "enabled": BADGES_ENABLED},
},
# .. setting_name: EVENT_BUS_PRODUCER_CONFIG['org.openedx.learning.badge.revoked.v1']
# ['learning-badges-lifecycle']['enabled']
Expand All @@ -570,7 +573,7 @@
# .. toggle_warning: The default may be changed in a later release.
# .. toggle_use_cases: opt_in
"org.openedx.learning.badge.revoked.v1": {
"learning-badges-lifecycle": {"event_key_field": "badge.uuid", "enabled": True},
"learning-badges-lifecycle": {"event_key_field": "badge.uuid", "enabled": BADGES_ENABLED},
},
}

Expand Down Expand Up @@ -600,7 +603,9 @@
"org.openedx.learning.ccx.course.passing.status.updated.v1",
],
"credly": {
"CREDLY_BASE_URL": "https://credly.com/",
"CREDLY_API_BASE_URL": "https://api.credly.com/v1/",
"CREDLY_SANDBOX_BASE_URL": "https://sandbox.credly.com/",
"CREDLY_SANDBOX_API_BASE_URL": "https://sandbox-api.credly.com/v1/",
"USE_SANDBOX": False,
},
Expand Down
Loading