fix: [ACI-973] make config's 'rules' key optional

raccoongang · May 9, 2024 · 95335a8 · 95335a8
1 parent bd253c6
commit 95335a8
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/credentials/apps/badges/tests/test_utils.py b/credentials/apps/badges/tests/test_utils.py
@@ -164,7 +164,7 @@ class TestGetEventTypeKeypaths(unittest.TestCase):
     def test_get_event_type_keypaths(self):
         result = get_event_type_keypaths("org.openedx.learning.course.passing.status.updated.v1")
 
-        for ignored_keypath in settings.BADGES_CONFIG["rules"].get("ignored_keypaths", []):
+        for ignored_keypath in settings.BADGES_CONFIG.get("rules", {}).get("ignored_keypaths", []):
             self.assertNotIn(ignored_keypath, result)
 
 class TestGetCredlyBaseUrl(unittest.TestCase):

diff --git a/credentials/apps/badges/utils.py b/credentials/apps/badges/utils.py
@@ -152,7 +152,7 @@ def get_data_keypaths(data):
                 f"{field.name}.{keypath}"
                 for keypath in get_data_keypaths(field.type)
                 if f"{field.name}.{keypath}"
-                not in settings.BADGES_CONFIG["rules"].get("ignored_keypaths", [])
+                not in settings.BADGES_CONFIG.get("rules", {}).get("ignored_keypaths", [])
             ]
         else:
             keypaths.append(field.name)