refactor: Block types processing refactoring #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myhailo-chernyshov-rg
force-pushed
the
myhailochernyshov/block-types-processing-refactoring
branch
2 times, most recently
from
e24e7cd to
de68907
Compare
myhailo-chernyshov-rg
changed the title
myhailo-chernyshov-rg
force-pushed
the
myhailochernyshov/block-types-processing-refactoring
branch
4 times, most recently
from
6a2f75f to
e12cbb8
Compare
NiedielnitsevIvan
requested changes
Jan 8, 2025
myhailo-chernyshov-rg
force-pushed
the
myhailochernyshov/block-types-processing-refactoring
branch
11 times, most recently
from
0a321da to
f80d0fc
Compare
myhailo-chernyshov-rg
force-pushed
the
myhailochernyshov/block-types-processing-refactoring
branch
2 times, most recently
from
50a33f9 to
1650432
Compare
myhailo-chernyshov-rg
force-pushed
the
myhailochernyshov/block-types-processing-refactoring
branch
from
1650432 to
1c28a30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is a problem that when we need to add a new block type processing, we need to change the code in several places: update
Cartridge.get_resource_contentto define the new processed content type, add the OLX creation logic for this content type toOlxExportand call it inOlxExport._create_olx_nodes.It is decided to create a separate class responsible for a block type processing. So, there are separate processors for HTML, LTI, QTI, Video etc. The list of block type processors are specified in settings, so we can control the processors to enable from settings. It will simlify a processor disabling if, for example, a third-party xblock created by the processor is not installed on the edX platform.
Depenencies
Supporting information
FC-0063
Deadline
"None"