Add Connection Pool Close configuration

[Gsantomaggio]

Closes: #388

[Gsantomaggio]

@jonnepmyra Can you please test it?

                ConnectionPoolConfig = new ConnectionPoolConfig()
                {
                    ConnectionCloseConfig = new ConnectionCloseConfig()
                    {
                        Policy = ConnectionClosePolicy.CloseWhenEmptyAndIdle,
                        IdleTime = TimeSpan.FromSeconds(60)
                    }
                }

[jonnepmyra]

Wow, that was fast :) , thank you!

I'm afraid that I will not be as fast ;), it may take a little longer than usual to test due to the holiday period, but I'll test as soon as possible!

[lukebakken]

@Gsantomaggio I did a quick initial review, check out the commit I just made. There is a TODO to be addressed, maybe?

[Gsantomaggio]

Thanks a lot @lukebakken

Here

rabbitmq-stream-dotnet-client/RabbitMQ.Stream.Client/ConnectionsPool.cs

Line 212 in 1814584

// TODO should everything be closed and cleaned-up here?

You raised a good point and an old "problem" of this client:
When you close the StreamSystem, the producers and consumers created by StreamSystem won't be closed.

The behaviour is different from Java and Go, see for example, Go Stream Client

We should also add this behaviour to this client, but it will introduce a sort of breaking change. Can we think of a 1.9 version?

The change has to deal with the auto-reconnect feature and close all the producers and consumers in the right way to avoid triggering the auto-reconnection

[jonnepmyra]

Hi,

I've tested this change and it looks great!

In my test case, I created short-lived consumers (create-consume-close) with a couple of seconds between each iteration.

Test results:

ConnectionClosePolicy.CloseWhenEmpty (as before this change):
Mean/avg consumer creation time: 9.88527 ms

ConnectionClosePolicy.CloseWhenEmptyAndIdle:
Mean/avg consumer creation time: 3.85261 ms

great work!

[Gsantomaggio]

@lukebakken To avoid inconsistency, I added a check during the pool connection close only in case the policy is CloseWhenEmptyAndIdle

That is not perfect, but it could be enough for the moment.

Version 2.0, we can think of adopting the same Golang and Java behaviour:

Close all the Producers and Consumers when the System is closed. 

This is a breaking change that I want to avoid introducing in this version.

With the policy CloseWhenEmpty ( default ) won't change anything btw.

@jonnepmyra thoughts?