Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting heartbeat timeout to TimeSpan.Zero #1773

Merged
merged 3 commits into from
Jan 30, 2025

Conversation

lukebakken
Copy link
Contributor

Fixes #1756

  • Add test that demonstrates the issue.

Fixes #1756

* Add test that demonstrates the issue.
@lukebakken lukebakken self-assigned this Jan 23, 2025
@lukebakken lukebakken added this to the 7.1.0 milestone Jan 23, 2025
@lukebakken lukebakken changed the title Improve error when disabling heartbeat Allow setting heartbeat timeout to TimeSpan.Zero Jan 24, 2025
@lukebakken lukebakken marked this pull request as ready for review January 24, 2025 15:25
@lukebakken
Copy link
Contributor Author

@Socolin @justcuriousstill

If you could test this PR in your environment, we would appreciate it. Thanks.

Copy link

@justcuriousstill justcuriousstill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested changes in my environment.

Tests.

Client Heartbeat Timeout = 0. Server Heartbeat Timeout = 60.
Expected Result = ArgumentOutOfRangeException not raised and a new connection with Heartbeat = 60 secs. PASS.

Client Heartbeat Timeout = 30. Server Heartbeat Timeout = 60.
Expected Result = ArgumentOutOfRangeException not raised and a new connection with Heartbeat = 30 secs. PASS.

Client Heartbeat Timeout = 90. Server Heartbeat Timeout = 60.
Expected Result = ArgumentOutOfRangeException not raised and a new connection with Heartbeat = 60 secs. PASS.

The Heartbeat Timeout behaviour now works as it did in v6 so thanks very much for resolving it so quickly.

@lukebakken
Copy link
Contributor Author

@justcuriousstill thank you for testing!

@lukebakken lukebakken merged commit 21fb198 into main Jan 30, 2025
16 checks passed
@lukebakken lukebakken deleted the rabbitmq-dotnet-client-1756 branch January 30, 2025 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exception when disabling heartbeat with v7
2 participants